Get rid of pytest.warns deprecation warning #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In ska3-prime (python 3.10) we get the following warning in unit tests:
This PR gets rid of that warning by explicitly setting the type of warning expected.
Interface impacts
Testing
Unit tests
Independent check of unit tests by Jean
Functional tests
I checked that the warning went away with this PR using ska3-flight 2023.1rc4
(I'm still getting a numpy DeprecationWarning on ctypeslib, but at least this PR cleans up the one from our own code -Jean).