Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De namespace #13

Merged
merged 3 commits into from
Jan 23, 2023
Merged

De namespace #13

merged 3 commits into from
Jan 23, 2023

Conversation

taldcroft
Copy link
Member

Description

Remove namespace package following the formalism in sot/ska_sun#22.

Interface impacts

None

Testing

Unit tests

  • No unit tests

Functional tests

  • Installed and confirmed expected packages / functions / versions
  • Built docs and confirmed they look reasonable

@javierggt
Copy link
Contributor

javierggt commented Jan 21, 2023

The documentation does not build for me:

  File "/Users/javierg/SAO/git/Ska.astro/docs/conf.py", line 23, in <module>
    from ska_astro import __version__
ImportError: cannot import name '__version__' from 'ska_astro' (unknown location)

and indeed I do not see __version__ defined anywhere. Perhaps a missing __init__.py?

@jeanconn
Copy link

Good point. I didn't try to build the docs but it looks like version was removed from astro.py .

@javierggt
Copy link
Contributor

javierggt commented Jan 21, 2023

After seeing that, I checked the PRs that were merged that I had not looked at, and this one also was missing __init__.py: sot/ska_arc5gl#14

@jeanconn
Copy link

Right. It looks like a few of these the version was probably moved into __init__.py and then maybe not checked in to version control? I fully expected to do need to go around and do some tiny fixes after we do more testing in the integ environment.

@taldcroft
Copy link
Member Author

I added the missing __init__.py.

@taldcroft taldcroft merged commit efece1c into master Jan 23, 2023
@taldcroft taldcroft deleted the de-namespace branch January 23, 2023 18:06
@javierggt javierggt mentioned this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants