Set tests to use a NETRC fixture instead of global

ska_ftp/tests/conftest.py

@@ -0,0 +1,6 @@
+import pytest
+import ska_ftp
+
+@pytest.fixture()
+def NETRC():
+    return ska_ftp.parse_netrc()

ska_ftp/tests/test_basic.py

@@ -10,11 +10,10 @@
 
 logger = pyyaks.logger.get_logger()
 
-NETRC = ska_ftp.parse_netrc()
 LUCKY = 'lucky.cfa.harvard.edu'
 
 
-def roundtrip(FtpClass, logger=None):
+def roundtrip(NETRC, FtpClass, logger=None):
     user = NETRC[LUCKY]['login']
     homedir = ('/home/' if FtpClass is ska_ftp.SFTP else '/') + user
     lucky = FtpClass(LUCKY, logger=logger)
@@ -42,17 +41,17 @@ def roundtrip(FtpClass, logger=None):
     assert orig == roundtrip
 
 
-def test_roundtrip():
+def test_roundtrip(NETRC):
     # roundtrip(FtpClass=ska_ftp.FTP, logger=logger)  # legacy of non-secure ftp
-    roundtrip(FtpClass=ska_ftp.SFTP, logger=logger)
+    roundtrip(NETRC, FtpClass=ska_ftp.SFTP, logger=logger)
 
 
-def test_roundtrip_no_logger():
+def test_roundtrip_no_logger(NETRC):
     # roundtrip(FtpClass=ska_ftp.FTP)
-    roundtrip(FtpClass=ska_ftp.SFTP)
+    roundtrip(NETRC, FtpClass=ska_ftp.SFTP)
 
 
-def test_sftp_mkdir_rmdir_rename():
+def test_sftp_mkdir_rmdir_rename(NETRC):
     user = NETRC[LUCKY]['login']
     homedir = '/home/{}'.format(user)
     lucky = ska_ftp.SFTP(LUCKY, logger=logger)
@@ -90,7 +89,7 @@ def test_delete_when_ftp_session_already_gone(capfd):
 def test_parse_netrc():
     cwd = os.path.dirname(__file__)
     netrc = ska_ftp.parse_netrc(os.path.join(cwd, 'netrc'))
-    assert netrc == {'test1': {'account': None,
+    assert netrc == {'test1': {'account': '',
                                'login': 'test1_login',
                                'password': 'test1_password'},
                      'test2': {'account': 'test2_account',