Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

De namespace #27

Merged
merged 2 commits into from
Jan 23, 2023
Merged

De namespace #27

merged 2 commits into from
Jan 23, 2023

Conversation

taldcroft
Copy link
Member

Description

Remove namespace package following the formalism in sot/ska_sun#22.

Interface impacts

None

Testing

Unit tests

  • Mac

Functional tests

  • Installed and confirmed expected packages / functions / versions + tests pass
  • Built docs and confirmed they look reasonable

javierggt
javierggt approved these changes Jan 21, 2023
View reviewed changes
Copy link
Contributor

@javierggt javierggt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@taldcroft taldcroft merged commit 81ed165 into master Jan 23, 2023
@taldcroft taldcroft deleted the de-namespace branch January 23, 2023 18:58
@javierggt javierggt mentioned this pull request Jan 23, 2023
Closed
@javierggt javierggt mentioned this pull request Mar 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanconn jeanconn jeanconn approved these changes

@javierggt javierggt javierggt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@taldcroft @javierggt @jeanconn