Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when running testr, avoid emitting this warning #10

Merged
merged 1 commit into from
Apr 22, 2020
Merged

when running testr, avoid emitting this warning #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ska_helpers/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,12 @@ def get_version(package, distribution=None):
# import but generate a lot of output indicating the problem.
import warnings
import traceback
warnings.warn(traceback.format_exc() + '\n\n')
warnings.warn('Failed to find a package version, setting to 0.0.0')
if 'TESTR_FILE' not in os.environ:
# this avoids a test failure when checking log files with this warning.
# Pytest will import packages such as Ska.Shell first as Shell and then as Ska.Shell.
# https://docs.pytest.org/en/latest/pythonpath.html
warnings.warn(traceback.format_exc() + '\n\n')
warnings.warn('Failed to find a package version, setting to 0.0.0')
version = '0.0.0'

return version
Expand Down