-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New utils: logger context manager and random RA and Decs #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
One thing is that maybe Thoughts? |
Regarding "One thing is that maybe set_log_level should live in the logging sub-module instead of utils." I thought that when I saw it but also figured it doesn't make much difference. |
@jeanconn - ok let's just leave it. |
2 tasks
jeanconn
approved these changes
Aug 13, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add two new functions to
ska_helpers.utils
:random_radec_in_cone()
: Get random sky coordinates within a cone.set_log_level()
: Context manager to temporarily set the log level for a loggerThis also includes ruff whitespace changes to four files.
Interface impacts
Adds functions.
Testing
Unit tests
Independent check of unit tests by Jean -
I note if I use
pytest -vs
there is some output printed, that I would think would be a problem for ska_testr:but ska_testr isn't catching that in the log checks for whatever reason so seems fine (and not due to this PR anyway).
Functional tests
random_radec_in_code
Looks like a random and spatially-uniform distribution: