Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

De-namespace #27

Merged
merged 3 commits into from
Jan 21, 2023
Merged

De-namespace #27

merged 3 commits into from
Jan 21, 2023

Conversation

taldcroft
Copy link
Member

Description

Remove namespace package following the formalism in sot/ska_sun#22.

Interface impacts

None

Testing

Unit tests

  • No unit tests

Functional tests

  • Install test and confirm expected functions in both locations
  • Build docs and confirm expected output

@jeanconn
Copy link
Contributor

There is a test.py that has a failed test with this branch, but it also fails on master.

@taldcroft taldcroft merged commit 9eb041d into master Jan 21, 2023
@taldcroft taldcroft deleted the de-namespace branch January 21, 2023 10:35
@javierggt javierggt mentioned this pull request Jan 23, 2023
Closed
@javierggt javierggt mentioned this pull request Mar 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanconn jeanconn jeanconn approved these changes

@javierggt javierggt Awaiting requested review from javierggt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taldcroft @jeanconn