Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-namespace #13

Merged
merged 2 commits into from
Jan 23, 2023
Merged

De-namespace #13

merged 2 commits into from
Jan 23, 2023

Conversation

taldcroft
Copy link
Member

Description

Remove namespace package following the formalism in sot/ska_sun#22.

Interface impacts

None

Testing

Unit tests

  • Mac (local test.py within git repo)

Functional tests

  • Installed and confirmed expected packages / functions / versions
  • Built docs and confirmed they look reasonable (fixed a latent problem in docs)

@javierggt
Copy link
Contributor

There are too many command-related libraries for my taste 😄

I just note that the new name is parsecm while up to now in other modules you have always used parse_cm. In the camel-case one could see the structure, but not anymore.

@taldcroft
Copy link
Member Author

@javierggt - this package is scheduled for removal this year, having been replaced by parse_cm. After ska3-prime I'll put an exception into the import with an env-var override. This way we will flush out any hidden dependencies and then finally remove this from ska3.

@taldcroft
Copy link
Member Author

This still needs approval.

Copy link
Contributor

@javierggt javierggt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I also built the docs and ran the test.

@taldcroft taldcroft merged commit 3288acf into master Jan 23, 2023
@taldcroft taldcroft deleted the de-namespace branch January 23, 2023 18:52
@javierggt javierggt mentioned this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants