Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Chandra.Time instead of mx.DateTime #1

Merged
merged 1 commit into from
Jun 22, 2015
Merged

Use Chandra.Time instead of mx.DateTime #1

merged 1 commit into from
Jun 22, 2015

Conversation

jeanconn
Copy link
Contributor

Use Chandra.Time instead of mx.DateTime

@jeanconn
Copy link
Contributor Author

I couldn't figure out a back-compatible approach to this transition here, so I just updated the scripts that call this package and have each to wrap the 'start' and 'stop' times in Chandra.Time.DateTime(), so those scripts are back compatible even if this package is not.

@taldcroft
Copy link
Member

What is not back-compatible about this PR?

@jeanconn
Copy link
Contributor Author

Some of the methods now return dicts with values as Chandra.Time.DateTime
objects instead of mx.DateTime objects.
On Jun 18, 2015 4:41 PM, "Tom Aldcroft" notifications@github.com wrote:

What is not back-compatible about this PR?


Reply to this email directly or view it on GitHub
#1 (comment).

@taldcroft
Copy link
Member

OK. I guess any scripts that call this and are still expecting an mx.DateTime object will fail quickly and not accidentally keep going and give wrong results?

@jeanconn
Copy link
Contributor Author

jeanconn commented Jun 18, 2015 via email

jeanconn added a commit that referenced this pull request Jun 22, 2015
Use Chandra.Time instead of mx.DateTime
@jeanconn jeanconn merged commit 6cd949a into master Jun 22, 2015
@jeanconn jeanconn deleted the no_mx branch June 22, 2015 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants