Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to support AGASC 1.8 promotion. #34

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Update to support AGASC 1.8 promotion. #34

merged 2 commits into from
Jul 9, 2024

Conversation

jeanconn
Copy link
Contributor

@jeanconn jeanconn commented Jul 8, 2024

Description

Update to support AGASC 1.8 promotion.
Remove defunct miniagasc.h5
Update proseco file to proseco_agasc_1p8.h5

Interface impacts

Testing

Unit tests

  • No unit tests

Functional tests

No functional testing.

@jeanconn
Copy link
Contributor Author

jeanconn commented Jul 8, 2024

I suppose my question is now if ska_sync should have proseco_agasc_1p7 and 1p8 so that folks can run proseco/sparkles unit tests - or if ska_sync is mostly for users who don't need it.

@jeanconn jeanconn changed the title Replace proseco 1p7 with 1p8 to support AGASC 1.8 promotion. Update to support AGASC 1.8 promotion. Jul 8, 2024
@jeanconn jeanconn requested review from javierggt and taldcroft July 8, 2024 18:28
Copy link
Member

@taldcroft taldcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeanconn jeanconn merged commit 0e6c9b5 into master Jul 9, 2024
@jeanconn jeanconn deleted the agasc_1p8 branch July 9, 2024 02:22
@javierggt javierggt mentioned this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants