Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert pip build.sh scripts to setup.py #20

Closed
jeanconn opened this issue Jul 10, 2018 · 4 comments
Closed

Convert pip build.sh scripts to setup.py #20

jeanconn opened this issue Jul 10, 2018 · 4 comments

Comments

@jeanconn
Copy link
Contributor

See discussion in #19

@jeanconn
Copy link
Contributor Author

It will probably be worth digging in a bit to see how the installs differ. Also see #18 for more discussion.

@jeanconn
Copy link
Contributor Author

jeanconn commented Jul 11, 2018

Looks like we if we stick with pip it should also have "--ignore-installed" in our version. I just ran into the issue where apparently pip it wouldn't let me make a conda package of Python module at a version because that package was installed in my environment at that version. Unlikely overall but annoying. (Actually, that just looks to be another bug in process or recipe, as I should be building in a naked environment so this should never happen)

@taldcroft
Copy link
Member

At some point we will be maintaining only Py3 versions of our namespace packages, at which point we can use native namespace packages. At that point we don't need --egg for those, FWIW. Or we can just use setup.py install --single-version-externally-managed.

@javierggt
Copy link
Contributor

This was one of the first things fixed in shiny, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants