Chandra.Time won't conda build in master

[jeanconn]

aca-presto% python ska_builder.py --build-root /export/aca/test-django/ Chandra.Time                       - Building package Chandra.Time.
  - Cloning or updating source source Chandra.Time.
  - Updated repo in /export/aca/test-django/src/Chandra.Time
  - Auto-checked out at 3.20.4 which is also tip of master
Traceback (most recent call last):
  File "setup.py", line 5, in <module>
    from Cython.Build import cythonize
ModuleNotFoundError: No module named 'Cython'
  - SKA_PKG_VERSION=

Looks like I need maybe need cython in the builder environment to make this work?

[jeanconn]

I think this will just be closed by

84d7850

[jeanconn]

@javierggt Do you understand this? I think the part that confused me was that Chandra.Time still has cython in the "build" dependencies in the recipe, but I think the code in ska_builder.py now that sets up SKA_PKG_VERSION needs to run setup.py first to do so before anything is passed to the conda build process. Am I understanding that correctly? So now that determining the version happens in the ska3_builder environment (and not the conda "build" environment) we need cython in the ska3_builder environment.

cc @taldcroft

[jeanconn]

Need to make a new version of ska3_builder to close this out.

[taldcroft]

Haven't tried, but I expect we could fix this by the following in setup.py of Chandra.Time.

try:
    from Cython.Build import cythonize
except ImportError:
    cythonize = lambda arg: None

Then python setup.py --version should work without Cython.

[jeanconn]

Good idea. I was thinking the same (that it shouldn't need Cython to get version) but I'm OK with this setup.py fix not getting in to 2020.1, depending on our schedule. We should probably clean this up and decide if we also update install_requires in Chandra.Maneuver

https://github.com/sot/Chandra.Maneuver/blob/9f54daafa8c3ceaa69b03912b597b47e784f6e53/setup.py#L16

[taldcroft]

What were you thinking of for the update to install_requires? Note that Cython is a build dependency but install_requires is about runtime dependencies (from my understanding).

[jeanconn]

I was mostly thinking about these as a set of "small changes to individual package setup.py pieces that would make sense in our current build system".