Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2020.1 #254

Merged
merged 47 commits into from
Jan 24, 2020
Merged

Release 2020.1 #254

merged 47 commits into from
Jan 24, 2020

Conversation

jeanconn
Copy link
Contributor

@jeanconn jeanconn commented Jan 9, 2020

Release Notes

The 2020.1 skare3 release is significant in that it includes substantive changes to a few packages and includes setuptools_scm modernization of most of our Python modules.

Package Updates

acis_taco

agasc

annie

Chandra.Maneuver

Chandra.Time

find_attitude

kadi

mica

ska_helpers

  • Initial Release 0.1.0
    • This new package includes a module version.py that provides functionality for getting a package version using either distribution metadata or git tag and commit data.
    • Also includes convenience methods to get and/or log runtime information like user, machine name etc for scripts.

ska.quatutil

ska_sync

Ska.Shell

sparkles

task_schedule

watch_cron_logs

xija

Includes just package changes for setuptools-scm

  • acdc, chandra_aca, Chandra.cmd_states, cxotime, hopper, maude, parse_cm, proseco, pyyaks, Ska.arc5gl, Ska.astro, Ska.DBI, Ska.File, Ska.Numpy, Ska.Matplotlib, Ska.ParseCM, Ska.tdb, starcheck, tables3_api, testr

ACIS packages with changes for setuptools-scm

  • acis_thermal_check, acisfp_check, backstop_history, dea_check, dpa_check, psmc_check

Updates to core/not-ska packages

  • setuptools_scm 3.3.3
  • django 3.0.1
  • sherpa to 4.11.1 on OSX

The spyder package has been removed from ska3-core

  • Remove spyder

Interface impacts

The package interface impacts are called out above (kadi and ska_sync).

xija has back-compatible API changes. xija allows models to specify timestep from the spec (but uses the default of 328 seconds for back-compatibility).

Review

All changes have been reviewed by the aspect team.

Testing

The updated set of modules pass unit and integration testing. In addition, the more involved testing for the kadi+django update was documented by Tom in [kadi PR 143](sot/kadi#143

Promotion

After approval, updated ska3-flight and ska3-perl will be installed on HEAD and GRETA ska3/flight.

The kadi package update will require minor updates to the kadi cron jobs.

The removal of spyder from the ska3-core package does not require that it be removed from HEAD/GRETA ska3/flight , though we do believe that no one is actually using the package.

Github

Closes #255
Closes #253
Closes #252
Closes #251
Closes #250
Closes #249
Closes #247
Closes #246
Closes #245
Closes #243
Closes #239
Closes #238
Closes #229
Closes #224
Closes #232


@jeanconn
Copy link
Contributor Author

I've updated the PR text with more content intended for external review (LR). If you have any comments or edits @taldcroft and @javierggt , please feel free.

@jeanconn jeanconn changed the title WIP: 2020.1 Release 2020.1 Jan 10, 2020
@jeanconn jeanconn force-pushed the 2020.1 branch 2 times, most recently from c8d946f to ba6cc13 Compare January 13, 2020 21:25
@jeanconn
Copy link
Contributor Author

The skare3 changes up through ba6cc13 correspond to the packages that are built and in ska3-conda and ska3-conda/test (ska3-flight pkg only) repos right now. This could go as a release if we run out of time before LR this week to do the rest.

@taldcroft
Copy link
Member

With the effort of integration testing and deploy, I'm fine with waiting another week and just doing one release.

@taldcroft
Copy link
Member

@javierggt - to close this out can you find someplace in the maintainer wiki to capture the versioning policy and edit accordingly. I note there are already things in there that are wrong with SCM versioning, for instance :

8. If necessary, do a quick PR to update the package version number. This is required if the current version in the code is the same as the last release tag.

@jeanconn
Copy link
Contributor Author

Regarding effort; I had already done the regression testing (ska_testr) on this set of package versions, but fine to defer overall for deploy effort as well (depending on how things move).

@jeanconn
Copy link
Contributor Author

Silly question, but what order should we use in the PR notes for the package updates? I think I started with "big" to "little" in substantive changes, but now it is just a mess.

@taldcroft
Copy link
Member

Doesn't matter to me...

@jeanconn
Copy link
Contributor Author

I think we'll need to fix sot/ska_helpers#7 (assuming it isn't some bizarre building or setup issue in my test environment) before promoting this.

@jeanconn
Copy link
Contributor Author

I've pulled Quaternion and am running the integration tests with the new ACIS packages.

@jeanconn jeanconn merged commit 3b15044 into master Jan 24, 2020
@jeanconn jeanconn deleted the 2020.1 branch January 24, 2020 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants