Bulk changes to the recipes and build order. #7

jeanconn · 2018-06-30T20:59:08Z

Bulk changes to the recipes and build order.

Fixes #3
Fixes #4

jeanconn · 2018-06-30T20:59:24Z

I started with individual commits and then it just got silly.

jeanconn · 2018-06-30T21:01:06Z

For a few of builds, I installed with pip instead of python setup.py install because it made the module tests work. If we don't care about the tests, I'm not sure if we care about the install, but I suspect this has something to do with egg dirs or whatnot and we should probably check that the built packages match what is somewhat expected to traverse them with testr.

taldcroft · 2018-06-30T22:46:24Z

I had assumed that using pip install per the spec in python_modules.cfg was the always the way to go. But I don't know if there are any unexpected interactions with conda.

jeanconn · 2018-06-30T22:53:04Z

And yes, for the few that failed I use the pip install per the python_modules.cfg spec. I think we can change them all, we'd probably just need to respect --egg. And yes, concern about interaction with the meta.yaml preserve_egg_dirs is why I didn't change this in bulk, though it should be easy to rebuild and retest if that's the way we end up going.

taldcroft

Some nits. Overall this is amazing!!!

taldcroft · 2018-07-02T10:07:16Z

ska_conda/pkg_defs/ska-flight/meta.yaml

+  # Packages required to run the package. These are the dependencies that
+  # will be installed automatically whenever the package is installed.
+  run:
+    - ska.shell ==3.3.3


Alphabetize for convenience in finding a package to update version.

Good point. We may end up doing this in other packages too, as largely they just accumulated dependencies as they were considered.

taldcroft · 2018-07-02T10:12:48Z

ska_conda/pkg_defs/mica/meta.yaml

+    - setuptools
+    - matplotlib
+    - numpy
+    - pytest


In general seems this should be testr, which is directly imported in the package and then requires pytest.

It looks like the mica test packages import pytest directly so I think it is fine to have them both (testr and pytest) even if you end up with redundancy in the dependency tree.

taldcroft · 2018-07-02T10:13:06Z

ska_conda/pkg_defs/mica/meta.yaml

+    - matplotlib
+    - numpy
+    - pytest
+    - django


For a bunch of packages, we have imports that are only used in certain circumstances. For mica, django is needed for mica.web. Obviously mica.web is useless unless we're running kadi webserver, in which case there is already a django.

I agree it is probably fine to remove django from here.

taldcroft · 2018-07-02T10:14:49Z

ska_conda/pkg_defs/mica/meta.yaml

+  run:
+    - python
+    - six
+    - setuptools


setuptools should not be an explicit runtime requirement.

Will check.

taldcroft · 2018-07-02T10:20:22Z

ska_conda/pkg_defs/maude/meta.yaml

    - six
    - scipy
    - numpy
-    - testr


testr is required to do import maude; maude.test().

I went back and forth on this and can obviously go back again. It did seem to me that testr is more of a test dependence than a runtime dependence, and in a real ska runtime environment, there's always going to be a testr... but if we want to make sure that each ska package is good about also pulling in testr from the dependency tree.. that's fine too.

If you are going to the trouble of enumerating Ska package dependencies at all, we should make them complete and not depend on being in a "real" Ska runtime. Otherwise we could pretty much skip all the meta.yaml run requirements (except for build-time testing).

OK, I'll move more of the test dependencies into the runtime area (without getting crazy).

taldcroft · 2018-07-02T10:24:04Z

ska_conda/pkg_defs/kadi/meta.yaml

@@ -29,7 +28,8 @@ requirements:
    - pytables
    - configobj
    - requests
-    - django
+    - tables3_api
+    - django <2.0


Nice way to encapsulate this locally!

taldcroft · 2018-07-02T10:42:24Z

ska_conda/build_order.txt

+cxotime
+annie
+ska-flight


The interface doc specifies ska3-flight. I went back and forth about whether to try being consistent with ska3 branding instead of ska to make this distinction clear to ourselves and end-users. In a few years the 3 might seem superfluous, but for now when we say "Ska flight" that is really Ska2 flight, so probably worth being rigorous in here.

jeanconn · 2018-07-02T12:04:30Z

ska_conda/pkg_defs/Chandra.Maneuver/meta.yaml

    - quaternion
    - chandra.time
    - ska.sun

 test:
+  requires:
+    - agasc


This is a case where we have some involved testing that seems to need agasc and Ska.engarchive. I suppose it would be fine to just add those as runtime dependencies, but it seemed overkill (they don't really seem like run-time requirements for the package even if they are needed to complete all of its tests).

Interesting web we are weaving. Agreed this is fine to leave as is.

taldcroft

It probably makes sense to just merge this now?

jeanconn · 2018-07-03T00:11:23Z

I've got some more 'misc' type stuff and that setuptools tweak and such that can probably go in here , but if you are waiting on this to do something, I can just put them in a new PR.

Bulk changes to the recipes and build order.

09be386

jeanconn mentioned this pull request Jun 30, 2018

kadi package provides Chandra.Time #3

Closed

taldcroft mentioned this pull request Jun 30, 2018

Django issues #4

Closed

Change ska to ska-flight in build order

93e0910

taldcroft reviewed Jul 2, 2018

View reviewed changes

jeanconn added 2 commits July 2, 2018 07:11

Rename ska-flight ska3-flight

520955f

Alphabetize pkg list in ska3-flight

1121c8a

jeanconn commented Jul 2, 2018

View reviewed changes

taldcroft approved these changes Jul 3, 2018

View reviewed changes

taldcroft merged commit e2f6421 into master Jul 3, 2018

taldcroft deleted the python_recipe_mods branch July 3, 2018 00:34

taldcroft mentioned this pull request Jul 3, 2018

Should we build noarch Python packages? #5

Closed

jeanconn mentioned this pull request Jan 21, 2020

Release 2020.1 #254

Merged

22 tasks

This was referenced May 21, 2020

Update sot/Ska.arc5gl to 3.1.4 #359

Closed

Update sot/Ska.astro to 3.2.4 #360

Closed

Update sot/Ska.ParseCM to 3.3.4 #366

Closed

javierggt added a commit that referenced this pull request Jul 21, 2020

workflow fix #7

2be82aa

This was referenced Oct 16, 2020

Update sot/Ska.Numpy to Release 3.9.0 #450

Closed

Update sot/cxotime to Release 3.2.0 #476

Closed

Update sot/perigee_health_plots to Release 0.1.0 #484

Closed

Update sot/aca_hi_bgd to Release 0.1.4 #487

Closed

javierggt mentioned this pull request Oct 27, 2020

Update sot/ska_path to Release 3.1.2 #497

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bulk changes to the recipes and build order. #7

Bulk changes to the recipes and build order. #7

jeanconn commented Jun 30, 2018 •

edited by taldcroft

Loading

jeanconn commented Jun 30, 2018

jeanconn commented Jun 30, 2018

taldcroft commented Jun 30, 2018

jeanconn commented Jun 30, 2018

taldcroft left a comment

taldcroft Jul 2, 2018

jeanconn Jul 2, 2018

taldcroft Jul 2, 2018

jeanconn Jul 2, 2018

taldcroft Jul 2, 2018

jeanconn Jul 2, 2018

taldcroft Jul 2, 2018

jeanconn Jul 2, 2018

taldcroft Jul 2, 2018

jeanconn Jul 2, 2018

taldcroft Jul 2, 2018

jeanconn Jul 2, 2018 •

edited

Loading

taldcroft Jul 2, 2018

taldcroft Jul 2, 2018

jeanconn Jul 2, 2018

taldcroft Jul 2, 2018

taldcroft left a comment

jeanconn commented Jul 3, 2018

Bulk changes to the recipes and build order. #7

Bulk changes to the recipes and build order. #7

Conversation

jeanconn commented Jun 30, 2018 • edited by taldcroft Loading

jeanconn commented Jun 30, 2018

jeanconn commented Jun 30, 2018

taldcroft commented Jun 30, 2018

jeanconn commented Jun 30, 2018

taldcroft left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jeanconn Jul 2, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

taldcroft left a comment

Choose a reason for hiding this comment

jeanconn commented Jul 3, 2018

jeanconn commented Jun 30, 2018 •

edited by taldcroft

Loading

jeanconn Jul 2, 2018 •

edited

Loading