Add compile arg for building on MacOS Catalina / Xcode 11.2 #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
|
This passes |
|
Great. I assume the setuptools_scm is good to go as well. Will this make Chandra.Time 3.20.4 or 3.21 or ? |
taldcroft
force-pushed
the
fix-build-on-catalina
branch
from
114d1c8 to
d237dd2
Compare
|
I just checked on the setuptools_scm working (it does) but noticed there is a conflict between the two. So I just rebased this on About the version, 3.20.4. I'm working on getting all the skare3 issues in to reflect package updates and version numbers. |
jeanconn
approved these changes
Jan 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is apparently needed to allow building Chandra.Time with the latest OS / tools on MacOS.
This includes and thus supercedes #36.
Testing
python setup.py testin a clean directory builds OK and passes tests onprestoCloses #36