Add get_stars() function to get multiple ids / dates #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 7, 2020
jeanconn
reviewed
Jan 9, 2020
| ok = has_pm & ~epoch_is_2000 | ||
| dyear[ok] = (DateTime(date) - DateTime(stars['EPOCH'][ok], format='frac_year')) / 365.25 | ||
| pm_to_degrees = dyear / (3600. * 1000.) | ||
| if np.asarray(date).shape == (): |
There was a problem hiding this comment.
@taldcroft Would you please remind me of the expected types and shapes of date? It isn't clear to me which problem this is code change is solving.
There was a problem hiding this comment.
Ah, I see. The new get_stars() routine repurposes add_pmcorr_columns() to receive date possibly as a thing with the same length as stars. I think add_pmcorr_columns probably needs a real docstring now and maybe a rename of date to dates in the args.
There was a problem hiding this comment.
Documentation update done. I left the arg as date on the off chance this non-public method is being used directly somewhere.
jeanconn
approved these changes
Jan 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is about 25 times faster than running
get_star()individually when getting large numbers of stars (e.g. more than 1000). On a fast SSD drive this runs in about 2 msec per star.Along the way I think I found a way to simplify the code wrt to the proper motion handling.