-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confirm that ska3-core is the minimal set of packages #36
Comments
Maybe right here we can start to capture the list of core packages that we'd like that may or may not be explicit dependencies of our other packages?
Others that we've used for analysis that are fine to keep as bonus items
Jean would like to add
|
I haven't used sqlalchemy in a long while and probably won't. Out of your list that is the only one I would vote to remove. And of course adding astroquery is great. BTW networkx is used in find_attitude, so that is a core dependency. |
I just updated my comment when I saw that sqlalchemy appears in kadi tests so should probably be in the kadi dependencies. find_attitude doesn't run in Py3 so isn't in here at all. |
Should probably also explicitly add yaml support (yaml, pyyaml) and the gitpython pieces as a nice-to-have. |
About kadi, do you mean the top-level https://github.com/sot/kadi/search?q=sqlalchemy&unscoped_q=sqlalchemy |
Yes, OK. If those test files aren't needed at all, I'll plan to remove sqlalchemy from the explicit list (will see if it gets installed as somebody else's dependence, but doesn't look like it from grepping around the the conda pkg dependencies). |
Done: sot/kadi#115 |
I added bokeh above and it looks like if we want mpld3 we'll need to build or find it it (no py36 conda package in our good channels). |
Added beautifulsoup4 above for aimpoint_mon (not that we're doing an operational transition today, just poking around a bit at dependencies). |
Is there ska code with an explicit dependence on zeromq? I'm noting that I'm not getting it automatically installed as a dependence on OSX and I'm wondering if I should add it to the list of things we want in the ska3-dev metapackage. |
IPython uses zeromq for IPC (https://ipython.org/ipython-doc/3/parallel/parallel_intro.html#security). I'm surprised this is not a dependence already. |
find_attitude? |
OK, so I still thought find_attitude was Py2 only which was why it is commented out in the py3 skare branch. |
We can skip mpld3 for now. It looks like there may be a new maintainer coming on board, but maybe mpld3 is not something we should baseline for active plots. The aimpoint_mon stuff can live without it by just making the static page. |
About find_attitude, yes, and now I remember you said that at least once before. That will have to come later. There shouldn't be any particular problem making it work on Py3 (hopefully!). |
WRT zeromq, on OSX it looks like I'm getting |
With regard to earlier comments in the thread, looks like astroquery isn't in the |
For testing you can try Jupyter notebook. If that works then I think all is good. |
I had, in fact, popped jupyter notebook up, but I wasn't sure how many paces to run through before deciding it was fine, or if I needed to run some test suite. Either way, I've added zeromq to the ska3-core build and will retest the new environment with regard to ska packages working and jupyter notebook working. |
But consider if current packages might be there for other reasons besides supporting ska3-flight packages?
In general, fixing (adding) back packages seems a reasonable approach if we identify dependencies.
The text was updated successfully, but these errors were encountered: