Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm that ska3-core is the minimal set of packages #36

Closed
taldcroft opened this issue Jul 23, 2018 · 20 comments
Closed

Confirm that ska3-core is the minimal set of packages #36

taldcroft opened this issue Jul 23, 2018 · 20 comments

Comments

@taldcroft
Copy link
Member

But consider if current packages might be there for other reasons besides supporting ska3-flight packages?

In general, fixing (adding) back packages seems a reasonable approach if we identify dependencies.

@jeanconn
Copy link
Contributor

jeanconn commented Jul 24, 2018

Maybe right here we can start to capture the list of core packages that we'd like that may or may not be explicit dependencies of our other packages?

  • ipython
  • nbconvert
  • jupyter
  • nb_conda (needed by jupyter to work in conda)
  • qt
  • pyqt
  • sphinx
  • yaml
  • pyyaml
  • git
  • beautifulsoup4

Others that we've used for analysis that are fine to keep as bonus items

  • pandas (more for Matt than us)
  • networkx
  • scikit-learn
  • line_profiler
  • pillow
  • spyder

Things I'm not sure we've used but maybe could be useful?

  • sqlalchemy (ah, it looks like this is a kadi test dependence that is not captured in the kadi deps)

Jean would like to add

  • astroquery
  • bokeh
  • gitpython

@taldcroft
Copy link
Member Author

I haven't used sqlalchemy in a long while and probably won't. Out of your list that is the only one I would vote to remove. And of course adding astroquery is great. BTW networkx is used in find_attitude, so that is a core dependency.

@jeanconn
Copy link
Contributor

I just updated my comment when I saw that sqlalchemy appears in kadi tests so should probably be in the kadi dependencies.

find_attitude doesn't run in Py3 so isn't in here at all.

@jeanconn
Copy link
Contributor

Should probably also explicitly add yaml support (yaml, pyyaml) and the gitpython pieces as a nice-to-have.

@taldcroft
Copy link
Member Author

About kadi, do you mean the top-level sqlalchemy directory? That is orphaned code from my first idea for kadi before settling on django. I should just remove that.

https://github.com/sot/kadi/search?q=sqlalchemy&unscoped_q=sqlalchemy

@jeanconn
Copy link
Contributor

Yes, OK. If those test files aren't needed at all, I'll plan to remove sqlalchemy from the explicit list (will see if it gets installed as somebody else's dependence, but doesn't look like it from grepping around the the conda pkg dependencies).

@taldcroft
Copy link
Member Author

Done: sot/kadi#115

@jeanconn
Copy link
Contributor

I added bokeh above and it looks like if we want mpld3 we'll need to build or find it it (no py36 conda package in our good channels).

@jeanconn
Copy link
Contributor

Added beautifulsoup4 above for aimpoint_mon (not that we're doing an operational transition today, just poking around a bit at dependencies).

@jeanconn
Copy link
Contributor

jeanconn commented Jul 24, 2018

I've started to capture this in an updated ska3-dev metapackages that just has what I think we want in the environment. The idea would be that you'd install ska3-dev while letting if float and then use the list of packages from defaults to make a new ska3-core list.

#33 0534535

@jeanconn
Copy link
Contributor

Is there ska code with an explicit dependence on zeromq? I'm noting that I'm not getting it automatically installed as a dependence on OSX and I'm wondering if I should add it to the list of things we want in the ska3-dev metapackage.

@taldcroft
Copy link
Member Author

IPython uses zeromq for IPC (https://ipython.org/ipython-doc/3/parallel/parallel_intro.html#security). I'm surprised this is not a dependence already.

@taldcroft
Copy link
Member Author

find_attitude?

@jeanconn
Copy link
Contributor

OK, so I still thought find_attitude was Py2 only which was why it is commented out in the py3 skare branch.

@taldcroft
Copy link
Member Author

We can skip mpld3 for now. It looks like there may be a new maintainer coming on board, but maybe mpld3 is not something we should baseline for active plots. The aimpoint_mon stuff can live without it by just making the static page.

@taldcroft
Copy link
Member Author

About find_attitude, yes, and now I remember you said that at least once before. That will have to come later. There shouldn't be any particular problem making it work on Py3 (hopefully!).

@jeanconn
Copy link
Contributor

WRT zeromq, on OSX it looks like I'm getting pyzmq from dependencies but not zeromq. Not sure about the best way to test IPython.

@jeanconn
Copy link
Contributor

With regard to earlier comments in the thread, looks like astroquery isn't in the defaults channel for now so that can wait.

@taldcroft
Copy link
Member Author

For testing you can try Jupyter notebook. If that works then I think all is good.

@jeanconn
Copy link
Contributor

I had, in fact, popped jupyter notebook up, but I wasn't sure how many paces to run through before deciding it was fine, or if I needed to run some test suite. Either way, I've added zeromq to the ska3-core build and will retest the new environment with regard to ska packages working and jupyter notebook working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants