Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ska3-core with arch-specific packages #33

Merged
merged 12 commits into from
Jul 26, 2018
Merged

ska3-core with arch-specific packages #33

merged 12 commits into from
Jul 26, 2018

Conversation

jeanconn
Copy link
Contributor

@jeanconn jeanconn commented Jul 17, 2018

Configure the ska3-core metapackage recipe to have arch-specific dependencies as needed.

Closes #36
Closes #24
Closes #42

- h5py ==2.7.0
- hdf5 ==1.8.17
- html5lib ==0.9999999
- html5lib ==0.9999999 [linux]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The html5lib folks need to commit to getting 1.0 out!!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah 😄

@jeanconn
Copy link
Contributor Author

jeanconn commented Jul 25, 2018

So the ska3-core updates in 0fb03f3 are what I get if I do a

conda install ska3-dev ska3-pinned

on new environments on both linux and osx machines, and then run

conda list --json > {os}.json

and then run the little script with those json files as input

python combine_arch.py --linux linux.json --osx osx.json --out package_list.txt

and then insert the package list into ska3-core. Still testing the environment you get from that. The little script uses the lower version if the package exists on both platforms, but does not use conda tools to confirm that package actually exists or is compatible with the other packages. I'm just hoping.

@jeanconn
Copy link
Contributor Author

I'm assuming we want to try to hold back packages on osx to somewhat match the linux versions (which are being held back by CentOS5) but I really don't know. Everything needs testing on both platforms (or eventually all three platforms) anyway.

@taldcroft
Copy link
Member

I'm assuming we want to try to hold back packages on osx to somewhat match the linux versions (which are being held back by CentOS5) but I really don't know.

That seems like a reasonable starting point. We'll see if problems come up in practice.

It's disturbing that a change in the conda bugfix version results in completely different package versions / builds. But maybe 4.3.21 is the last one that doesn't go for the hashed-version builds?

It looks like this package does have some mismatched dependencies and the
lowest version approach in combine_arch.py does not work.  Using
zeromq==4.1.3 results in an unsatisfiable dependence on Linux without
helpful debugging info, so I just set this to use version from each platform.
@jeanconn
Copy link
Contributor Author

"But maybe 4.3.21 is the last one that doesn't go for the hashed-version build?" I think that 4.3.25 is probably the last one that doesn't use the newer file areas that have the hash builds

https://github.com/conda/conda/blob/master/CHANGELOG.md#4326-2017-09-15

But when I was looking for CentOS5 compatibility it looked like 4.3.21 was the last one actually built on the old os. So I think it is a reasonable compromise for now. .

@jeanconn
Copy link
Contributor Author

Do you want changes to the combine_arch script or process here @taldcroft or is this OK for this PR and we'll do more changes as needed in a new PR after testing?

@taldcroft
Copy link
Member

This is ok. Approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants