Remove pyrightconfig.json file from templates #1402
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that adding a
pyrightconfig.json
file is a bad idea: microsoft/pylance-release#6446Basically adding even an empty
pyrightconfig.json
file ends up turning on type checking (it setspython.analysis.TypeCheckingMode
tostandard
. Then simple code like this gets a warning:So we should remove this config file from our repos and individual users will need to configure VS code:
I think the other
ignore
values are not really needed in practice, but pylance really doesn't deal well with notebooks.