Add local astropy #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanconn
commented
Jul 26, 2018
| @@ -6,7 +6,9 @@ | |||
| ska_conda_path = os.path.abspath(os.path.dirname(__file__)) | |||
| pkg_defs_path = os.path.join(ska_conda_path, "pkg_defs") | |||
| build_list = os.path.join(ska_conda_path, "build_order.txt") | |||
| no_source_pkgs = ['ska3-flight', 'ska3-core', 'ska3-dev', 'ska3-pinned', 'ska3-template'] | |||
| no_source_pkgs = ['ska3-flight', 'ska3-core', 'ska3-dev', 'ska3-pinned', 'ska3-template', | |||
There was a problem hiding this comment.
We probably rename 'no_source_pkgs' to something that makes it more clear that the packages in this list just don't use the local convention we're using that about: home: has the url for a git repository that we build a custom package from using the git tags.
jeanconn
force-pushed
the
add_local_astropy
branch
from
13432bf to
f6ac572
Compare
jeanconn
commented
Jul 26, 2018
| - python | ||
| - setuptools | ||
| - numpy ==1.12.1 | ||
| - llvmlite ==0.18.0 |
There was a problem hiding this comment.
I changed these to be very specific to our install. I think this works out so that our recipe/astropy build will be naturally deprecated when we no longer have these pins.
jeanconn
commented
Jul 26, 2018
| - setuptools | ||
| - numpy ==1.12.1 | ||
| - llvmlite ==0.18.0 | ||
| - gcc ==4.8.5 [linux] |
There was a problem hiding this comment.
Also, this would not build build on CentOS5 with native gcc 4.1.2 . This suggests to me that we should add a gcc/libgcc on our few other linux-64 packages.
This is the conda-forge version from https://github.com/conda-forge/astropy-feedstock.git skare3 could use an astropy 3.0.3 built against numpy 1.12 and there isn't one in the defaults channels (limited to CentOS5 packages).
jeanconn
force-pushed
the
add_local_astropy
branch
from
f6ac572 to
ea059af
Compare
taldcroft
approved these changes
Jul 26, 2018
This was referenced Oct 16, 2020
This was referenced Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bundle a recipe for astropy (and some test dependencies) in skare3 to give us an astropy 3.0.3 that will still run on our CentOS5-compatible Linux env.