Put an arc5gl in ska3-template and set for RH8

[jeanconn]

Description

Updates for RH8:

• Put an arc5gl in SKA/bin
• Set the flight arc5gl to use the flight ascds env by default
• Update LD_LIBRARY_PATH to not have SKA/lib

Interface impact

Testing:
For testing, I set /proj/sot/ska3/test-rh8 to have these changes + updated eng_archive + update ska.shell module + updated ska.arc5gl module.

ska.arc5gl                3.2.1.dev5+g49d217b            py_0    file:///proj/sot/ska/jeanproj/git/skare3/builds
ska.engarchive            4.55.3                   py38_0    https://icxc.cfa.harvard.edu/aspect/ska3-conda/masters
ska.shell                 3.5.1                      py_0    https://icxc.cfa.harvard.edu/aspect/ska3-conda/masters
ska3-template             2022.06.02                    0    file:///proj/sot/ska/jeanproj/git/skare3/builds

Unit tests

• ska_testr - all tests pass in that Linux test environment on owen-v (RH8) and fido (CentOS7).

Functional tests

• Perl pieces
  • task_schedule - I manually ran most of the tests in task_schedule successfully in owen-v. It looks like the test_fail test does not timeout appropriately, but this looks to not be a regression (same thing happens in flight ska3 on fido) so that is outside of the scope of this testing.
  • starcheck - I ran test starcheck on fido and owen-v and flight starcheck on fido and confirmed all text outputs are equivalent and the plot looks the same by eye. I think this is basically what our ska_testr starcheck regress process is supposed to do but I don't think we're using it.
  • arc5gl - I confirmed arc5gl from the test environment fetched a file manually on owen-v and fido.
  • replan central - I installed the latest version of replan central in /proj/sot/ska3/test-rh8 and configured its cron job to run from owen-v. Web outputs are at: https://cxc.cfa.harvard.edu/mta/ASPECT/arc3_rh8_test/. Since at promotions we'll still be running this from CentOS7, I'll swap the test cron job to fido and confirm no errors.

[javierggt]

I would figure out issue #856 first, because I would bundle them.

[jeanconn]

I think we've hesitated in the past to remove $SKA/lib from LD_LIBRARY_PATH because we didn't define a test plan for the perl code #73 or anything else that might by dynamically linked and need those $SKA/lib libraries.

So I suppose this would need more comprehensive testing for starcheck, Replan Central, arc5gl, and task_schedule to start.

I don't care about needing to support the other perl code (aca_egse splat) if we can just run them from an old environment and certify aca_view.

[jeanconn]

I think this is also independent of #856 , but this would need to be retested with that.

[javierggt]

Why is perlwrap needed here?

[jeanconn]

I duplicated the functionality that was in the previous arc5gl (/proj/sot/ska/bin/arc5gl) that called a perl that was always configured to have the skare3 environment variables from the #! without requiring that the user be "in" a skare3 environment. I couldn't figure out how to do that without a wrapper. If we don't need to have that functionality we can remove it, but I also figured it didn't cost much.

[javierggt]

I figured that is what the skare script is for, but I don't know where perlwrap is used.

[jeanconn]

The perlwrap is used in the #! line of arc5gl. I tried to use skare directly in a #! line like

#!/usr/bin/env /proj/sot/ska3/flight/bin/skare perl

and that just gives

/usr/bin/env: /proj/sot/ska3/flight/bin/skare perl: No such file or directory

I didn't explore how to call env more if there is another trick to that.

[jeanconn]

It looks like, technically, RH8 supports the use of the "-S" flag to env, so this would work:

#!/usr/bin/env -S /proj/sot/ska3/flight/bin/skare perl

But that doesn't work with /usr/bin/env in CentOS7.

[jeanconn]

@taldcroft Can you think of a need to have arc5gl run directly without having HEAD ska environment variables sourced? I figured it was more work/testing to remove functionality but am not attached to it. While I am used calling /proj/sot/ska/bin/arc5gl directly by hand (and probably have an alias somewhere), I could just update my SOP or any aliases to call skare directly before calling arc5gl.

When it comes to perl stuff, I suppose telem_archive and fid_drift_mon probably will not run on RH8 even from the ska2 environment, so not sure if we want to finally fix that or just try to keep them running from CentOS7 indefinitely.

[taldcroft]

Can you think of a need to have arc5gl run directly without having HEAD ska environment variables sourced?

I personally would never think to do that. I'd type ska3 like I do a dozen+ times a day and then type arc5gl. Is that your question?

• telem_archive: we really need to just track down if that is doing anything any more.
• fid_drift_mon: time to port to ska3.

[jeanconn]

Maybe that is my question... What are you doing now to run arc5gl because I figure you aren't sourcing into ska2? Or just doesn't come up?

[taldcroft]

I would use my ska alias to source in to Ska2. But in practice I am using arc5gl manually only very rarely these days.

[taldcroft]

Some quick research:

• telem_archive: we really need to just track down if that is doing anything any more.
  • This creates an observations table that does get used in a few places. It should be straightforward to use kadi commands v2 get_observations instead, but it will take some effort.
• fid_drift_mon: time to port to ska3.
  • The core data collection here is an old perl script. It would be best to port to Python but that is probably a day or two of work end to end.

[taldcroft]

Maybe we need a new quango which is stuck at CentOS-7 for a while to support Ska2.

[jeanconn]

Yes, if we get to that point (no CentOS7) we could do that. I might also be able to keep the ska2 working on RH8 with a couple of direct edits to those versions of the perl modules.

[javierggt]

Reading this thread... it seems like if this solves the issue, then we should merge, right? (and the thing about telem_archive and fid_drift_mon is a digression).

[jeanconn]

Yes, the handling of the other perl stuff (old ska2 that might not run on RH8) is a digression. Since neither of you seem to want the perl wrapper in arc5gl I've removed it, though that does mean I'll need to redo my testing thus far.

[taldcroft]

To be clear, I have no strong opinions about implementation, except:

• It works on CentOS-7 and RH8
• We get this done in finite time. 😄

[jeanconn]

I think my testing of this (which was basically against the draft environment) is sufficient.

[javierggt]

I'm ok with merging, rebasing 2022.6 on top of this and continuing.

[jeanconn]

OK. Merged.

[jeanconn]

I'm not sure how things are set to kick off a new build of ska3-template, otherwise it can be built manually.

[taldcroft]

Well this is exciting, long time coming!!