In get_conda_pkg_info: do not have subprocess.run check the return code. #111
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some unwanted output, and fixes
packages.get_conda_pkg_info
so it works for github repositories that do not have a corresponding package with the same name.The code was searching for a conda package named the same way as the repo, which is trivially not true in repos that have no package at all.
This is a trivial change. Basically, the
check
argument passed tosubprocess.run
was popped from a kwargs variable that was local and never had thecheck
key, so it was always being set toTrue
. Also,check=True
was obviously not the original intent of this code, since right after the call tosubprocess.run
the output was being parsed and inspected for errors, optionally ignoring them in exactly the cases we care about.This affects nothing we care about. After the PR, there will be package info for these repos, but we do not care about them.
Description
Fixes #
Interface impacts
Testing
Unit tests
Functional tests
Ran the update dashboard script and there was no unwanted output.