Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve info provided by ska3_update_summary #74

Merged
merged 4 commits into from
Dec 10, 2020
Merged

Conversation

javierggt
Copy link
Collaborator

@javierggt javierggt commented Nov 17, 2020

This PR includes a few changes to the scripts used to edit skare3 release PRs.

Changes:

  • modify ska3_update_summary to be able to handle ska3-core[-latest] and to include added/removed packages.
  • parse conda package deps using space between package name and version. When running conda search --json with older conda versions, the separator between package and version was '==', now it is a space.
  • add author information to the list of changes between releases
  • when querying the issues related to a milestone, sort them by issue ID.

@taldcroft
Copy link
Member

Can you add in the description what is driving this change? It looks fine but I'm curious and good to have something for the record.

@javierggt
Copy link
Collaborator Author

Sorry, I added a few little commits, so now this PR is bigger.

@taldcroft
Copy link
Member

I'm assuming you are basically going in single-developer mode on this package and not planning to review. Let me know otherwise but I want to make sure you are not waiting on review.

@javierggt javierggt changed the title parse conda package deps using space between package name and version Improve info provided by ska3_update_summary Dec 10, 2020
@javierggt javierggt merged commit 9328b8e into master Dec 10, 2020
@javierggt javierggt mentioned this pull request Mar 2, 2021
@javierggt javierggt deleted the shiny-fixes branch April 5, 2021 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants