Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Enable releases with closed PRs #85

Merged
merged 1 commit into from
Dec 13, 2021
Merged

Conversation

javierggt
Copy link
Collaborator

On release workflow, require the existence of an open PR only if it is a prerelease, otherwise accept closed PRs as well.

…s a prerelease, otherwise accept closed PRs as well.
@javierggt javierggt changed the title Fix: Accept releases with closed PRs Fix: Enable releases with closed PRs Dec 13, 2021
Copy link
Contributor

@jeanconn jeanconn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@javierggt javierggt merged commit 411f90c into master Dec 13, 2021
@javierggt javierggt deleted the release-closed-pr branch July 12, 2022 15:34
@javierggt javierggt mentioned this pull request Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants