Remove use of --tags option to git

[javierggt]

Description

This PR introdues changes to skare3_promote.py to remove uses of the --tags argument to git. This option does not exist anymore.

Fixes #93

Interface impacts

None

Testing

Unit tests

• No unit tests
• Mac
• Linux
• Windows

Independent check of unit tests by [REVIEWER NAME]

• [PLATFORM]:

Functional tests

No functional testing.

[taldcroft]

I don't recall that there was ever a --tags option for git fetch (maybe wrong though), but there was and still is git fetch --tag. This has always confused me and I often will try the wrong one first.

[javierggt]

Actually, the --tags options did not go away. You can see it in their online docs (https://git-scm.com/docs/git-fetch), so you must be confused.

Your comment made me look into it a bit more, and this seems a bug in gitpython. This is the python code that is run:

repo = git.Repo()
repo.remotes.origin.fetch("--tags")

In the newer version, it tries to run:

git fetch -v -- origin --tags

and this fails with the error couldn't find remote ref --tags. The same command fails in the current ska3-flight, so the problem is how gitpython assembled the command.

[taldcroft]

Huh, I would swear I tried git fetch --tags this morning and it didn't work, but I agree now with what you are saying.