Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rounded values for checks where appropriate #153

Merged
merged 1 commit into from
May 24, 2021

Conversation

taldcroft
Copy link
Member

Description

The general load review policy is to do numerical checks based on the rounded floating point representation of a value as presented in the reports or warning messages. For example the guide count is presented to 2 decimal places, so that should be used in the check. Otherwise one gets confusing messages like in #110.

Testing

  • Passes unit tests on MacOS
  • [N/A] Functional testing

Fixes #152

@taldcroft taldcroft requested a review from jeanconn April 13, 2021 13:10
@taldcroft taldcroft merged commit 8b77b7b into master May 24, 2021
@taldcroft taldcroft deleted the use-rounded-checks branch May 24, 2021 12:45
This was referenced Jun 30, 2021
@javierggt javierggt mentioned this pull request Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Round to two places to do guide_count check
2 participants