Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update roll review test for up to 5.2 mag stars #163

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Update roll review test for up to 5.2 mag stars #163

merged 1 commit into from
Oct 13, 2021

Conversation

jeanconn
Copy link
Contributor

@jeanconn jeanconn commented Oct 13, 2021 •
edited
Loading

Description

Update roll review test for up to 5.2 mag stars

With the change in proseco to allow up-to-5.2 mag star selection, the test_review_roll_options test now has a new option with a 5.4 mag BOT star.

Testing

  • Passes unit tests on MacOS, linux, Windows (at least one required)
  • Functional testing - this change is a unit test update.. which is the functional test

@jeanconn jeanconn requested a review from taldcroft October 13, 2021 16:35
@jeanconn jeanconn merged commit 9c0efe1 into master Oct 13, 2021
@jeanconn jeanconn deleted the bright-star-roll-option branch October 13, 2021 22:56
This was referenced Oct 25, 2021
Closed
Merged
@javierggt javierggt mentioned this pull request May 18, 2022
Closed
@javierggt javierggt mentioned this pull request Aug 3, 2022
Merged
@javierggt javierggt mentioned this pull request Sep 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taldcroft taldcroft taldcroft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeanconn @taldcroft