Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying all roll options from command line #164

Merged
merged 1 commit into from
Oct 19, 2021

Conversation

taldcroft
Copy link
Member

Description

In one real-life situation I wanted to run roll optimization from the command line with non-default parameters. Instead I had to manually read in the pickle in IPython and do things by hand. This update allows doing this with a single command line entry.

Testing

  • Passes unit tests on MacOS, linux, Windows (at least one required)
  • Functional testing

Functional testing

Some examples of functional testing, where the results looked reasonable each time.

10057  python -m sparkles ~/Downloads/OCT1121_final_2021_278_10_07_41_080.pkl.gz --obsid 26155 --roll-level=critical --roll-method=uniform --open-html --help
10058  python -m sparkles ~/Downloads/OCT1121_final_2021_278_10_07_41_080.pkl.gz --obsid 26155 --roll-level=critical --roll-method=uniform --open-html --roll-min-improvement=-10
10059  python -m sparkles ~/Downloads/OCT1121_final_2021_278_10_07_41_080.pkl.gz --obsid 26155 --roll-level=critical --roll-method=uniform --open-html --roll-min-improvement=-10 --roll-max-roll-deviation=3
10060  python -m sparkles ~/Downloads/OCT1121_final_2021_278_10_07_41_080.pkl.gz --obsid 26155 --roll-level=critical --roll-method=uniform --open-html --roll-min-improvement=-10 --roll-max-roll-dev=3
10061  python -m sparkles ~/Downloads/OCT1121_final_2021_278_10_07_41_080.pkl.gz --obsid 26155 --roll-level=critical --roll-method=uniform --open-html --roll-min-improvement=-10 --roll-max-roll-dev=1 --roll-d-roll=0.1 --roll-max-roll-options=30
10062  python -m sparkles ~/Downloads/OCT1121_final_2021_278_10_07_41_080.pkl.gz --obsid 26155 --roll-level=critical --roll-method=uniform --open-html --roll-min-improvement=-10 --roll-d-roll=0.5 --roll-max-roll-options=40
10063  python -m sparkles ~/Downloads/OCT1121_final_2021_278_10_07_41_080.pkl.gz --obsid 26155 --roll-level=critical --open-html --roll-min-improvement=-10 --roll-max-roll-options=40
10064  python -m sparkles ~/Downloads/OCT1121_final_2021_278_10_07_41_080.pkl.gz --obsid 26155 --roll-level=critical --open-html --roll-min-improvement=-10 --roll-max-roll-options=40 --roll-max-roll-dev=1
10066  time python -m sparkles ~/Downloads/OCT1121_final_2021_278_10_07_41_080.pkl.gz --obsid 26155 --roll-level=critical --roll-method=uniform --open-html --roll-min-improvement=-10 --roll-d-roll=0.5 --roll-max-roll-options=1000

@taldcroft taldcroft force-pushed the roll-args-from-command-line branch from a8277d8 to 91065eb Compare October 18, 2021 19:45
@taldcroft taldcroft requested a review from jeanconn October 18, 2021 19:45
@taldcroft taldcroft merged commit 89818d8 into master Oct 19, 2021
@taldcroft taldcroft deleted the roll-args-from-command-line branch October 19, 2021 23:23
@javierggt javierggt mentioned this pull request Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants