Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pitch/roll table #167

Closed
wants to merge 1 commit into from
Closed

Update pitch/roll table #167

wants to merge 1 commit into from

Conversation

jeanconn
Copy link
Contributor

Description

Update pitch/roll table

The values come from pitch_roll_2021_spm_phase3.xlsx sent 16-Dec-2021.
That file has signed/positive and negative roll ranges but all the magnitudes
are the same for each sign for each row, so reduced the table to the
unsigned version.

Testing

  • Passes unit tests on MacOS, linux, Windows (at least one required)
  • Functional testing

It isn't functional testing, but as a sanity check I just plotted the rolldev in the old and new files and confirmed for myself they are different

update_pitch_roll

and then for functional testing confirmed that the allowed_rolldev function works and gets different answers around the "throat" at 135:

Flight:

In [1]: from sparkles.roll_optimize import allowed_rolldev                      
In [2]: allowed_rolldev(135)                                                    
Out[2]: 18.7487718079
In [3]: allowed_rolldev(138)                                                    
Out[3]: 7.334

PR

In [1]: from sparkles.roll_optimize import allowed_rolldev                           
In [2]: allowed_rolldev(135)                                                         
Out[2]: 13.979
In [3]: allowed_rolldev(138)                                                         
Out[3]: 14.516

Fixes sot/ska_sun#18 (basically)

The values come from pitch_roll_2021_spm_phase3.xlsx sent 16-Dec-2021.
That file has signed/positive and negative roll ranges but all the magnitudes
are the same for each sign for each row, so reduced the table to the
unsigned version.
@jeanconn
Copy link
Contributor Author

jeanconn commented Mar 2, 2022

Superseded by #168

@jeanconn jeanconn closed this Mar 2, 2022
@jeanconn jeanconn deleted the new-roll-table branch March 28, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update roll range table
1 participant