Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linting with ruff and add workflow for black + ruff #188

Merged
merged 6 commits into from
Jun 16, 2023
Merged

Conversation

taldcroft
Copy link
Member

@taldcroft taldcroft commented May 27, 2023

Description

  • Start from pandas ruff configuration
  • Add workflow for Python linting with black and ruff

Interface impacts

Testing

Still needs sot/ska_helpers#32 and sot/ska_sun#27 for current unit tests.

Unit tests

  • Mac

Independent check of unit tests by Jean

  • Linux

Functional tests

No functional testing.

@taldcroft taldcroft requested a review from jeanconn May 29, 2023 23:58
Copy link
Contributor

@jeanconn jeanconn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests passing seems sufficient review for these changes.

@jeanconn jeanconn merged commit fc3d169 into master Jun 16, 2023
@jeanconn jeanconn deleted the ruff branch June 16, 2023 14:48
@jeanconn jeanconn mentioned this pull request Jun 23, 2023
@javierggt javierggt mentioned this pull request Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants