Pin chandra_models version to 3.48 for tests #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taldcroft
approved these changes
Jul 7, 2023
This was referenced Jul 12, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pin chandra_models version to 3.48 for tests
Interface impacts
Testing
I checked out chandra_models at 3.49, set CHANDRA_MODELS_REPO_DIR to /Users/jean/git/chandra_models, set CHANDRA_MODELS_DEFAULT_VERSION to pitch-roll-constraint-2023_020, and confirmed test failures without this PR.
Unit tests
Independent check of unit tests by @taldcroft:
chandra_modelsrepo checked out at 3.49 andCHANDRA_MODELS_DEFAULT_VERSIONunset.Functional tests
Unit testing is functional testing for this change.