Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a different bad star for bad star test #211

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Conversation

jeanconn
Copy link
Contributor

@jeanconn jeanconn commented Aug 19, 2024

Description

Use a different bad star for bad star test

Fixes issue that the test was based on bad star 260713672, that was removed from the bad star list.

Interface impacts

Testing

Unit tests

  • Mac arm64
(ska3) flame:sparkles jean$ git rev-parse HEAD
6a5fef42d6169c08a602c213e1995990bc233f32
(ska3) flame:sparkles jean$ pytest
========================================================================================== test session starts ==========================================================================================
platform darwin -- Python 3.11.8, pytest-8.0.2, pluggy-1.4.0
rootdir: /Users/jean/git
configfile: pytest.ini
plugins: timeout-2.2.0, anyio-4.3.0
collected 103 items                                                                                                                                                                                     

sparkles/tests/test_checks.py ............................................................................                                                                                        [ 73%]
sparkles/tests/test_find_er_catalog.py .....                                                                                                                                                      [ 78%]
sparkles/tests/test_review.py ..................                                                                                                                                                  [ 96%]
sparkles/tests/test_yoshi.py ....                                                                                                                                                                 [100%]

========================================================================================= 103 passed in 26.89s                                                                                                                                                                      

Independent check of unit tests by [REVIEWER NAME]

  • [PLATFORM]:

Functional tests

No functional testing.

@jeanconn jeanconn requested a review from javierggt August 19, 2024 17:09
Copy link
Contributor

@javierggt javierggt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes make sense to me.

I ran the tests on master (fail) and on the branch (success).

@jeanconn jeanconn merged commit ab63afa into master Aug 21, 2024
2 checks passed
@jeanconn jeanconn deleted the fewer-bad-stars branch August 21, 2024 17:17
@javierggt javierggt mentioned this pull request Nov 7, 2024
@javierggt javierggt mentioned this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants