Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 25 arcsec to margin for fid spoiling per #251 #286

Merged
merged 2 commits into from
Jan 17, 2019
Merged

Add 25 arcsec to margin for fid spoiling per #251 #286

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30d9c75
Add 25 arcsec to margin for fid spoiling per #251
taldcroft Jan 17, 2019
225a782
Declare fid_spoil_margin correctly
jeanconn Jan 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion starcheck/src/lib/Ska/Starcheck/Obsid.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1438,9 +1438,16 @@ sub check_star_catalog {

# Check for situation that occurred for obsid 14577 with a fid light
# inside the search box (PR #50).

if ($type =~ /BOT|ACQ/){
# Margin for fid spoiling the acquisition star is the search box halfwidth
# plus the uncertainty in fid position. See starcheck #251 for justification
# of the 25 arcsec value here.
my $fid_spoil_margin = $halfw + 25.0;

for my $fpos (@fid_positions){
if (abs($fpos->{y} - $yag) < $halfw and abs($fpos->{z} - $zag) < $halfw){
if (abs($fpos->{y} - $yag) < $fid_spoil_margin and
abs($fpos->{z} - $zag) < $fid_spoil_margin){
if ($type =~ /ACQ/){
push @yellow_warn, sprintf "$alarm [%2d] Fid light in search box\n", $i;
}
Expand Down