Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all make_stars stuff #361

Merged
merged 1 commit into from
Jan 13, 2021
Merged

Remove all make_stars stuff #361

merged 1 commit into from
Jan 13, 2021

Conversation

jeanconn
Copy link
Contributor

Description

Remove all make_stars stuff

This includes an update to the load review checklist.

Testing

  • Passes unit tests on MacOS, linux, Windows (at least one required)
    • has no unit tests
  • Functional testing
    • ran on a recent week and see expected lack of make_stars

@jeanconn jeanconn requested a review from taldcroft January 11, 2021 17:20
@jeanconn jeanconn merged commit 8c25973 into master Jan 13, 2021
@jeanconn jeanconn deleted the make_stars branch January 13, 2021 13:39
This was referenced Apr 2, 2021
Closed
Merged
@javierggt javierggt mentioned this pull request Apr 12, 2021
Closed
@javierggt javierggt mentioned this pull request Jul 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taldcroft taldcroft taldcroft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeanconn @taldcroft