Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove special case ER checks #362

Merged
merged 2 commits into from
Jan 15, 2021
Merged

Remove special case ER checks #362

merged 2 commits into from
Jan 15, 2021

Conversation

jeanconn
Copy link
Contributor

Description

Remove special case ER checks

I've left this in the load review checklist, so if it comes up again we can revisit using those rules.

Testing

  • Passes unit tests on MacOS, linux, Windows (at least one required)
    • No unit tests
  • Functional testing
    • Ran on a recent schedule without erroring out

Fixes #

@jeanconn jeanconn requested a review from taldcroft January 11, 2021 17:20
@taldcroft
Copy link
Member

You should remove the same from the review checklist since we are no longer checking this. If something drastic changes then we revert this PR to put it back.

@jeanconn
Copy link
Contributor Author

OK. I figured not removing the checklist section was one option, as not checking for special case ers means not relaxing a set of criteria, and we'd have the checklist handy to review one manually if it got all red warnings. Removing the checklist item I suppose puts this squarely in requiring SSAWG review, but it was getting there anyway.

@taldcroft
Copy link
Member

The special-case ER was an artifact of the OFLS scheduler. We won't ever use that again, so the thing which is known as a special-case ER will never happen. There might be something else that requires a new rule, but it won't be that.

@jeanconn
Copy link
Contributor Author

OK. I've removed the checklist block. I thought there could still be a reason to run an ER with "relaxed" star field constraints if it is running outside of perigee, but if it is just not going to come up that is fine.

@jeanconn jeanconn merged commit dd38bf7 into master Jan 15, 2021
@jeanconn jeanconn deleted the special_er branch January 15, 2021 14:49
@javierggt javierggt mentioned this pull request Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants