Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove checks for flickering pixel mon windows #364

Merged
merged 1 commit into from
Jan 13, 2021
Merged

Remove checks for flickering pixel mon windows #364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 0 additions & 36 deletions starcheck/src/lib/Ska/Starcheck/Obsid.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1785,42 +1785,6 @@ sub check_star_catalog {
push @{$self->{yellow_warn}}, @yellow_warn;
}

#############################################################################################
sub check_flick_pix_mon {
#############################################################################################
my $self = shift;

# this only applies to ERs (and they should have numeric obsids)
return unless ( $self->{obsid} =~ /^\d+$/ and $self->{obsid} >= $ER_MIN_OBSID );

my $c;
# Check for existence of a star catalog
return unless ($c = find_command($self, "MP_STARCAT"));

# See if there are any monitor stars. Return if not.
my @mon_stars = grep { $c->{"TYPE$_"} eq 'MON' } (1..16);
return unless (@mon_stars);

for my $mon_star (@mon_stars){

push @{$self->{fyi}}, sprintf("Obsid contains flickering pixel MON\n");


push @{$self->{warn}}, sprintf("[%2d] Monitor Commanding. Size is not 8x8\n", $mon_star)
unless $c->{"SIZE${mon_star}"} eq "8x8";

push @{$self->{warn}}, sprintf("[%2d] Monitor Commanding. Monitor Window RESTRK should be 0\n", $mon_star)
unless $c->{"RESTRK${mon_star}"} == 0;

# Verify the DTS is set to self
push @{$self->{warn}}, sprintf("[%2d] Monitor Commanding. DTS should be set to self\n", $mon_star)
unless $c->{"DIMDTS${mon_star}"} == $c->{"IMNUM${mon_star}"};

}


}


#############################################################################################
sub check_monitor_commanding {
Expand Down
1 change: 0 additions & 1 deletion starcheck/src/starcheck.pl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,7 +540,6 @@ sub json_obsids{
$obs{$obsid}->{compass_file} = "$STARCHECK/compass$obs{$obsid}->{obsid}.png";
}
$obs{$obsid}->check_monitor_commanding(\@bs, $or{$obsid});
$obs{$obsid}->check_flick_pix_mon();
$obs{$obsid}->set_dynamic_mag_limits();
$obs{$obsid}->check_dither($dither);
# Get the args that proseco would want
Expand Down