Add track overlap check #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't put permanent output into a tmp dir : Ran on NOV2921A, output https://icxc.cfa.harvard.edu/aspect/tmp/starcheck-pr380/starcheck.html#obsid45890. |
|
The description is too terse. Think of the PR description being something that external reviewers might quickly glance at, or more likely that we might view in 5 years. |
|
Can you copy/paste the relevant starcheck output into the description in case someone is viewing this without being on VPN? |
taldcroft
reviewed
Dec 16, 2021
|
Ah. If we've decided we want the test outputs to be permanent that's fine. |
|
Or should the output just live in the PR? Maybe that is the most sustainable choice. |
taldcroft
reviewed
Dec 16, 2021
Merged
This was referenced Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add track overlap check.
The PEA discards a readout window that overlaps with another window. Review of the guide star tracking data (for the agasc supplement update) from the NOV2921A schedule shows that a guide star was frequently lost due to overlap with another guide star window.
The existing spoiler checks in selection and review have prevented most overlapping stars from occurring, but the NOV2921A star selection shows that two selectable guide stars could be selected with the existing code within 35 arcsecs and have no starcheck warning. This PR adds a check that two tracked items (MON, FID, GUI, BOT) are not within 60 arcsecs.
Testing