Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Inline::Python with a light Python function server #402

Merged
merged 30 commits into from
Jan 6, 2023
Merged

Replace Inline::Python with a light Python function server #402

Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
e14e616
Apparently working w/ time conversions
taldcroft Dec 30, 2022
c0b7b7b
Vectorize date2time for backstop
taldcroft Dec 30, 2022
c552e4c
Apply black/isort to utils.py
taldcroft Dec 30, 2022
d6450f4
Running to completion
taldcroft Dec 30, 2022
a795acc
Remove final INLINE refs (env vars)
taldcroft Dec 30, 2022
dce71d8
Minor cleanup
taldcroft Dec 30, 2022
58c11e3
Get free port and secure comm w/ key
taldcroft Dec 31, 2022
b7aeb60
Add functionality to collect call statistics
taldcroft Dec 31, 2022
a4f57d9
Reduce some Python calls and cut unused processing
taldcroft Dec 31, 2022
38beb17
No limit on number of obsids
taldcroft Dec 31, 2022
4ada1e6
Vectorize yagzag_to_pixels call
taldcroft Jan 1, 2023
d6087bd
Don't call pixel_to_yagzag for bad pixels
taldcroft Jan 1, 2023
c95b910
More performance and code tidy
taldcroft Jan 1, 2023
79c351f
Start server in the main starcheck process (don't fork)
taldcroft Jan 5, 2023
86c39d6
Add a server timeout (probably not needed?)
taldcroft Jan 5, 2023
69105ce
More verbose server timeout text
jeanconn Jan 5, 2023
dc8a6b6
Put GetOptions earlier in the code
jeanconn Jan 5, 2023
3cc1cf4
Only show server calls if verbose > 1
jeanconn Jan 5, 2023
7f73242
Put usage() right after GetOptions
jeanconn Jan 5, 2023
9a54ead
Set max_obsids by cmdline option
jeanconn Jan 5, 2023
05a1002
Update dither parsing comments
jeanconn Jan 5, 2023
bed6674
If we have two dither errors, keep them.
jeanconn Jan 5, 2023
5bc68f0
Remove unused Dumper import
jeanconn Jan 5, 2023
1011893
Increase server timeout to 180s
jeanconn Jan 5, 2023
2d35131
Change check on kadi log level to be gt
jeanconn Jan 5, 2023
c5ea583
Use Dumper instead of Dump
jeanconn Jan 5, 2023
d719afd
Configure output to work with -verbose
jeanconn Jan 5, 2023
dec5dbb
Add help for verbosity
jeanconn Jan 5, 2023
5be93b4
Fix guide summ bug introduced in #389
jeanconn Jan 5, 2023
65ae9aa
Remove defunct decode()s
jeanconn Jan 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions starcheck/src/starcheck.pl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,8 +440,7 @@
$obs{$oflsid}->add_guide_summ($oflsid, \%guidesumm);
}
else {
my $obsid = $obs{$oflsid}->{obsid};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I probably should have left this line (the print warning statement is likely going to also spit out an "undefined $obsid" warning. But I'll fix it in a future PR).

my $cat = Ska::Starcheck::Obsid::find_command($obs{$obsid}, "MP_STARCAT");
my $cat = Ska::Starcheck::Obsid::find_command($obs{$oflsid}, "MP_STARCAT");
if (defined $cat){
push @{$obs{$oflsid}->{warn}}, sprintf("No Guide Star Summary for obsid $obsid ($oflsid). \n");
}
Expand Down