Add a unit test for dyn bgd hotpix imposter calc

[jeanconn]

Description

Add a unit test for dyn bgd hotpix imposter calc. Maybe it is a bridge too far for the #412 PR, but we could start to accumulate Python unit tests here as we go. This is not a particularly clean unit test; I suppose it would be better to ask sparkles what we want for dyn_bgd_n_faint and dyn_bgd_dt_ccd or some such? But this does work as a functional test for the imposter calc.

This addresses the issue at the end of #412 that the functional testing of the imposter calculation was not demonstrated.

Interface impacts

Testing

I tested this with install testing into my ska3-matlab-2023.4rc6 environment.

Unit tests

• Mac

Independent check of unit tests by [REVIEWER NAME]

• [PLATFORM]:

Functional tests

No functional testing.

[jeanconn]

@taldcroft I don't know if we actually want to merge this or something like it, but it seemed a reasonable way to document what I did for functional test.

[taldcroft]

This looks great! There was only one real issue with using >= or <= instead of splitting to > and ==. Then I saw an opportunity to simplify the code and started typing.

[jeanconn]

OK. Thanks. I just committed your changes and re-ran the test successfully.

[jeanconn]

This is a PR against #412, so my preference would be to get #412 approved without this, get this approved, and then merge them both.

[taldcroft]

Looks good now. I ran the test and got a pass. Not required, but probably worth cleaning up these warnings by preceding the regex string with r.

============================================= warnings summary ==============================================
starcheck/pcad_att_check.py:51
  /Users/aldcroft/git/starcheck/starcheck/pcad_att_check.py:51: DeprecationWarning: invalid escape sequence '\d'
    match = re.match('^(\d+\.\d+)\s+\|\s+(\S+)\s*$',

starcheck/pcad_att_check.py:67
  /Users/aldcroft/git/starcheck/starcheck/pcad_att_check.py:67: DeprecationWarning: invalid escape sequence '\d'
    match = re.match('^(\d+\.\d+)\s+\|\s+(\S+)\s+(\S+)\s+(\S+)\s+(\S+)\s*', line)

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

[jeanconn]

Thanks! And I'm fine with making those regex changes if we are fine with a "starcheck still seemed to run ok" test for the record as enough testing for that.

[jeanconn]

Though actually... what are you doing to see those pcad_att_check warnings?