Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ccd_temp instead of t_ccd from dark cal data #419

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Conversation

jeanconn
Copy link
Contributor

@jeanconn jeanconn commented Jul 11, 2023

Description

Use ccd_temp instead of t_ccd from dark cal data.
The 't_ccd' value is only available for acdc dark cals starting in 2019. The ccd_temp value is equal to t_ccd for modern calibrations and exists for the older ones.

Interface impacts

Testing

Unit tests

  • Mac

Independent check of unit tests by [REVIEWER NAME]

  • [PLATFORM]:

Functional tests

Functionally, the ska_testr regression test runs MAY2019A as the test and that failed against master with:

Traceback (most recent call last):
  File "/Users/jean/miniconda3/envs/ska3-matlab-2023.4rc6/lib/python3.10/site-packages/starcheck/server.py", line 71, in handle
    result = func(*args, **kwargs)
  File "/Users/jean/miniconda3/envs/ska3-matlab-2023.4rc6/lib/python3.10/site-packages/starcheck/utils.py", line 329, in check_hot_pix
    dark_t_ccd = dark_props["t_ccd"]
KeyError: 't_ccd'

With this PR there is no exception.

@jeanconn jeanconn requested a review from taldcroft July 11, 2023 15:37
@jeanconn jeanconn merged commit 2b6a98d into master Jul 11, 2023
@jeanconn jeanconn deleted the dark-t-ccd branch July 11, 2023 15:45
@javierggt javierggt mentioned this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants