Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHINY: Use legacy np printoptions for regression consistency #16

Merged
merged 1 commit into from
Jun 25, 2020

Conversation

taldcroft
Copy link
Member

Description

Numpy 1.14 improved printing of arrays but this changes the encoded array data for generating pseudo-random but reproducible numbers. For compatibility with the 1.12 formatting that forms the basis of regression testing, use the old style here.

Testing

  • Passes unit tests on MacOS (shiny)
  • Passes unit tests on MacOS (flight)
  • [N/A] Functional testing

@taldcroft taldcroft requested a review from jzuhone June 24, 2020 15:27
@taldcroft taldcroft merged commit 3babafd into master Jun 25, 2020
@taldcroft taldcroft deleted the shiny-tests branch June 25, 2020 14:01
@javierggt javierggt mentioned this pull request Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants