Use submitted test-spec as a full filename #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taldcroft
approved these changes
Jul 11, 2018
|
This was approved, but is it still OK or do we want to set the test spec option to work either with a file or a string? |
|
@javierggt @taldcroft I'm wondering about closing these out in testr. Do you two care about this API change? I would still prefer to just use full filename but don't know if we need to code to allow it either way. |
|
I'm 👍 on merging this. The magic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use submitted test-spec as a full filename
I keep trying to tab complete my test-spec file. Instead of fixing my tabbing, can we just have run_testr --test-spec take a file argument (instead of the string at the back half of the file)?