Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore deprecation warning that comes from external packages #37

Merged
merged 4 commits into from
Jan 27, 2022

Conversation

javierggt
Copy link
Contributor

@javierggt javierggt commented Dec 6, 2021

Description

While preparing ska3-next (sot/skare3/pull/755) some warnings popped up. I added them here to discuss whether to ignore them or fix them before ska3-next. This change causes the warnings to be ignored.

  • Since Numpy 1.20.0, numpy.object is deprecated. PyTable still uses it and this shows this warning:
    `np.object` is a deprecated alias for the builtin `object`
    
  • conda-build requires jinja2 <3.0.0, and jinja2 2.* together with MarksupSafe lead to this warning:
    'soft_unicode' has been renamed to 'soft_str'
    
  • a warning in annie I have not yet decided what to do with.

Testing

  • [n/a] Passes unit tests on MacOS, linux, Windows (at least one required)
  • Functional testing: all run_testr tests pass if the proseco, acis_thermal_check, starcheck and Ska.Matplotlib PRs are merged.

Fixes #

@javierggt
Copy link
Contributor Author

This is one of the issues for ska3-next

@javierggt javierggt mentioned this pull request Jan 20, 2022
@javierggt javierggt changed the title Ignore deprecation warning that comes from PyTables Ignore deprecation warning that comes from external packages Jan 24, 2022
@javierggt javierggt merged commit 8eba475 into master Jan 27, 2022
@javierggt javierggt mentioned this pull request Feb 8, 2022
3 tasks
@javierggt javierggt deleted the np-deprecation-warning branch April 20, 2022 20:27
@javierggt javierggt mentioned this pull request Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant