Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove PYTEST_IGNORE_WARNINGS from setup_helper #49

Merged
merged 1 commit into from
Feb 13, 2023
Merged

remove PYTEST_IGNORE_WARNINGS from setup_helper #49

merged 1 commit into from
Feb 13, 2023

Conversation

javierggt
Copy link
Contributor

@javierggt javierggt commented Feb 13, 2023 •
edited by jeanconn
Loading

Description

Remove remaining use of PYTEST_IGNORE_WARNINGS.

Fixes #48

Interface impacts

Testing

Unit tests

  • No unit tests

Functional tests

I ran the following on the Quaternion local repo, using this PR on top of a 2023.1rc7 environment:

python setup.py test

@javierggt javierggt requested a review from jeanconn February 13, 2023 16:40
jeanconn
jeanconn approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@jeanconn jeanconn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. In my local copy I went with

args = shlex.split(self.args) if self.args else []

though I don't know if there is anything saved with the one-liner.

@javierggt javierggt merged commit 4df4f38 into master Feb 13, 2023
@javierggt javierggt deleted the rm-ignore-warning branch February 13, 2023 19:31
@javierggt javierggt mentioned this pull request Feb 13, 2023
Closed
@javierggt javierggt mentioned this pull request Mar 13, 2023
Merged
@javierggt javierggt mentioned this pull request May 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanconn jeanconn jeanconn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PYTEST_IGNORE_WARNINGS not removed everywhere
2 participants
@javierggt @jeanconn