Refactor heat.py into a subpackage #129
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
heat.py
currently contains all of the classes which model heating inputs. Currently, this file is quite bloated, containing all currently used classes, as well as some which are no longer used.This PR refactors this structure, while leaving the API intact, by changing
heat.py
into aheat
subpackage. The files underheat
are now:base.py
: base heating classesgeneric.py
: generic heating classes (this could be merged into the one above potentially)solar.py
: all of the solar heating classesearth.py
: the earthshine in the ACIS radiator FOV codeelectronics.py
: heating from electronics boxesI also put deprecated classes into a new file,
deprecated.py
, under thecomponent
subpackage.This PR also:
DpaSolarHeat
copy of theSolarHeatHrc
classfrom future import print_function
call at the top ofheat.py
Interface impacts
Since this is just code reorganization under the hood, but all imports from the xija API should be the same, there should be no interface impacts.
Testing
Unit tests
Independent check of unit tests by @taldcroft
Functional tests
xija_gui_fit
andacis_thermal_check
tests pass.