-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
2 changed files
with
39 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
# Set to true to add reviewers to pull requests | ||
addReviewers: true | ||
|
||
# Set to true to add assignees to pull requests | ||
addAssignees: true | ||
|
||
# A list of reviewers to be added to pull requests (GitHub user name) | ||
reviewers: | ||
- Draply | ||
- 0x5ea000000 | ||
- hduoc2003 | ||
- zk-steve | ||
- Tranduy1dol | ||
- VanhGer | ||
|
||
# A list of keywords to be skipped the process that add reviewers if pull requests include it | ||
skipKeywords: | ||
- wip | ||
|
||
# A number of reviewers added to the pull request | ||
# Set 0 to add all the reviewers (default: 0) | ||
numberOfReviewers: 0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
# Check List | ||
|
||
- [ ] Don't forget to squash commits into meaningful chunks before merging | ||
- [ ] Check every test passed. | ||
- [ ] Did you split imports into std and custom parts? | ||
- [ ] Have you updated the consts in ORN? | ||
- [ ] Have you run ORN with the latest version? | ||
- [ ] Check your commit messages. | ||
- [ ] Have you added meaningful comments? | ||
- [ ] Don't forget to optimize gas cost! | ||
- [ ] Calling vector::length() multiple times is expensive (e.g. in loops), save it to a variable instead. | ||
- [ ] Consider using consts for things that can be pre-computed. | ||
- [ ] `pow(2, x) => (1 << x+1)` | ||
- [ ] `inline` short functions to save gas. | ||
- [ ] Find all vector::empty() in all files and replace them with the first append | ||
- [ ] Use vector::\*\_reverse\_\*() version to save gas. | ||
- [ ] Check Visibility of functions |