Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove eventLoop parameter from async execute APIs #549

Merged
merged 2 commits into from
Jun 18, 2023

Conversation

adam-fowler
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jun 17, 2023

Codecov Report

Merging #549 (63af705) into 7.x.x (6f2e293) will increase coverage by 0.04%.
The diff coverage is 96.61%.

@@            Coverage Diff             @@
##            7.x.x     #549      +/-   ##
==========================================
+ Coverage   74.28%   74.33%   +0.04%     
==========================================
  Files          80       80              
  Lines        8373     8388      +15     
==========================================
+ Hits         6220     6235      +15     
  Misses       2153     2153              
Impacted Files Coverage Δ
...s/SotoCore/AWSClient+EndpointDiscovery+async.swift 45.87% <75.00%> (-0.59%) ⬇️
Sources/SotoCore/AWSClient+async.swift 94.23% <100.00%> (+0.66%) ⬆️
Sources/SotoCore/HTTP/AsyncHTTPClient.swift 89.06% <100.00%> (+1.13%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@adam-fowler adam-fowler requested a review from 0xTim June 17, 2023 09:58
@adam-fowler adam-fowler changed the title Remove eventLoop from async execute APIs Remove eventLoop parameter from async execute APIs Jun 17, 2023
@adam-fowler adam-fowler force-pushed the remove-eventloop-from-async-api branch from 2e5b53a to d3cd795 Compare June 18, 2023 09:17
@adam-fowler adam-fowler force-pushed the remove-eventloop-from-async-api branch from d3cd795 to 53bd2a6 Compare June 18, 2023 09:44
Sources/SotoCore/AWSClient+async.swift Outdated Show resolved Hide resolved
@adam-fowler adam-fowler merged commit db45f85 into 7.x.x Jun 18, 2023
@adam-fowler adam-fowler deleted the remove-eventloop-from-async-api branch June 18, 2023 11:42
adam-fowler added a commit that referenced this pull request Jul 5, 2023
* Remove eventLoop from execute commands

* Remove commented out code
adam-fowler added a commit that referenced this pull request Jul 5, 2023
* Remove eventLoop from execute commands

* Remove commented out code
adam-fowler added a commit that referenced this pull request Jul 5, 2023
* Remove eventLoop from execute commands

* Remove commented out code
adam-fowler added a commit that referenced this pull request Jul 5, 2023
* Remove eventLoop from execute commands

* Remove commented out code
adam-fowler added a commit that referenced this pull request Jul 24, 2023
* Remove eventLoop from execute commands

* Remove commented out code
adam-fowler added a commit that referenced this pull request Jul 29, 2023
* Remove eventLoop from execute commands

* Remove commented out code
adam-fowler added a commit that referenced this pull request Aug 12, 2023
* Remove eventLoop from execute commands

* Remove commented out code
adam-fowler added a commit that referenced this pull request Dec 24, 2023
* Remove eventLoop from execute commands

* Remove commented out code
adam-fowler added a commit that referenced this pull request Apr 5, 2024
* Remove eventLoop from execute commands

* Remove commented out code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants