Merge request and response types #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 7.x.x #569 +/- ##
==========================================
- Coverage 78.87% 78.86% -0.02%
==========================================
Files 71 73 +2
Lines 6292 6467 +175
==========================================
+ Hits 4963 5100 +137
- Misses 1329 1367 +38
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
No need to include in this PR
adam-fowler
force-pushed
the
merge-request-response
branch
from
ccaf8e8
to
80cd46b
Compare
0xTim
approved these changes
Jul 27, 2023
| @@ -576,52 +576,6 @@ class AWSClientTests: XCTestCase { | |||
| } | |||
| } | |||
|
|
|||
| /// verify we are not calling the Retry handler when streaming a request | |||
| func testDontRetryStreamingRequests() async { | |||
There was a problem hiding this comment.
I'm assuming we don't need this test anymore? I can't see it transferred anywhere
There was a problem hiding this comment.
Yes we don't need it anymore. Previously I couldn't run retry on streamed responses because they called a callback for each data chunk. If you retried the request you could be sending the same data twice. Now we return the header and an async sequence with the body data and this is no longer a concern.
You can see in AWSClient.swift line 451 the related code has been deleted
adam-fowler
added a commit
that referenced
this pull request
Jul 29, 2023
* reorder execute * process response in execute * Collapse AWSHTTPResponse and AWSResponse into one * Collpase AWSRequest and AWSHTTPRequest into one * Add HTTP to request and response type names * Remove new middleware until we need it No need to include in this PR * Remove re-org to make PR review easier * Changes from PR comments * Another fix
adam-fowler
added a commit
that referenced
this pull request
Aug 12, 2023
* reorder execute * process response in execute * Collapse AWSHTTPResponse and AWSResponse into one * Collpase AWSRequest and AWSHTTPRequest into one * Add HTTP to request and response type names * Remove new middleware until we need it No need to include in this PR * Remove re-org to make PR review easier * Changes from PR comments * Another fix
adam-fowler
added a commit
that referenced
this pull request
Dec 24, 2023
* reorder execute * process response in execute * Collapse AWSHTTPResponse and AWSResponse into one * Collpase AWSRequest and AWSHTTPRequest into one * Add HTTP to request and response type names * Remove new middleware until we need it No need to include in this PR * Remove re-org to make PR review easier * Changes from PR comments * Another fix
adam-fowler
added a commit
that referenced
this pull request
Apr 5, 2024
* reorder execute * process response in execute * Collapse AWSHTTPResponse and AWSResponse into one * Collpase AWSRequest and AWSHTTPRequest into one * Add HTTP to request and response type names * Remove new middleware until we need it No need to include in this PR * Remove re-org to make PR review easier * Changes from PR comments * Another fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWSRequest and AWSHTTPRequest have been merged to AWSHTTPRequest
AWSResponse and AWSHTTPResponse have been merged to AWSHTTPResponse
As request doesn't include some information it had before which was used in middleware this has been moved to the middleware context.