Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import SotoXML as implementation only #573

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Conversation

adam-fowler
Copy link
Member

SotoXML is an internal module which shouldn't be used outside of SotoCore

@adam-fowler adam-fowler requested a review from 0xTim July 29, 2023 10:08
@codecov
Copy link

codecov bot commented Jul 29, 2023

Codecov Report

Merging #573 (333def8) into 7.x.x (c58aa23) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##            7.x.x     #573   +/-   ##
=======================================
  Coverage   78.86%   78.86%           
=======================================
  Files          73       73           
  Lines        6467     6467           
=======================================
  Hits         5100     5100           
  Misses       1367     1367           
Files Changed Coverage Δ
Sources/SotoCore/AWSClient.swift 90.88% <ø> (ø)
Sources/SotoCore/Concurrency/EventStream.swift 95.91% <ø> (ø)
Sources/SotoCore/Doc/AWSShape+Encoder.swift 100.00% <ø> (ø)
Sources/SotoCore/Encoder/EventStreamDecoder.swift 77.85% <ø> (ø)
...ces/SotoCore/Message/Middleware/S3Middleware.swift 67.24% <ø> (ø)
Sources/SotoCore/HTTP/AWSHTTPResponse.swift 96.01% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@adam-fowler adam-fowler merged commit 74a4123 into 7.x.x Aug 2, 2023
@adam-fowler adam-fowler deleted the implementation-only-xml branch August 2, 2023 06:52
adam-fowler added a commit that referenced this pull request Aug 12, 2023
* import SotoXML as implementation only

* formatting
adam-fowler added a commit that referenced this pull request Dec 24, 2023
* import SotoXML as implementation only

* formatting
adam-fowler added a commit that referenced this pull request Apr 5, 2024
* import SotoXML as implementation only

* formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants