-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request encoding user info #576
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 7.x.x #576 +/- ##
==========================================
+ Coverage 79.11% 81.22% +2.11%
==========================================
Files 78 77 -1
Lines 6512 6457 -55
==========================================
+ Hits 5152 5245 +93
+ Misses 1360 1212 -148
... and 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
adam-fowler
force-pushed
the
request-encoding-user-info
branch
from
August 6, 2023 12:08
bd76668
to
aa5f2a9
Compare
0xTim
approved these changes
Aug 7, 2023
adam-fowler
added a commit
that referenced
this pull request
Aug 12, 2023
* Add RequestEncodingContainer, pass to encoders * Fixup checksum tests * Get rid of all uses of Mirror, fix Payloads * Fix requests with payload and headers * Move URL building to RequestEncoderContainer * Changes to get services woking * Add EventPayload * Fix up tests * Conform AWSEventStream to decodable * Make RequestContainer code inlinable * Rename decode functions to align with RequestContainer * comments * Remove unused code * Add SingleValueEncodingContainer.encodeNil * add file header * Add more tests * More tests
adam-fowler
added a commit
that referenced
this pull request
Dec 24, 2023
* Add RequestEncodingContainer, pass to encoders * Fixup checksum tests * Get rid of all uses of Mirror, fix Payloads * Fix requests with payload and headers * Move URL building to RequestEncoderContainer * Changes to get services woking * Add EventPayload * Fix up tests * Conform AWSEventStream to decodable * Make RequestContainer code inlinable * Rename decode functions to align with RequestContainer * comments * Remove unused code * Add SingleValueEncodingContainer.encodeNil * add file header * Add more tests * More tests
adam-fowler
added a commit
that referenced
this pull request
Apr 5, 2024
* Add RequestEncodingContainer, pass to encoders * Fixup checksum tests * Get rid of all uses of Mirror, fix Payloads * Fix requests with payload and headers * Move URL building to RequestEncoderContainer * Changes to get services woking * Add EventPayload * Fix up tests * Conform AWSEventStream to decodable * Make RequestContainer code inlinable * Rename decode functions to align with RequestContainer * comments * Remove unused code * Add SingleValueEncodingContainer.encodeNil * add file header * Add more tests * More tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RequestEncodingContainer
class that holds references to request headers, query parameters and uri.AWSHTTPRequest
.encode(to:)
that uses the aboveResponseDecodingContainer
function names to the same asRequestEncodingContainer